Skip to content

Fixed Invalid value for field rateLimitOptions when updating RegionSecurityPolicy rules#16757

Merged
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
matheusaleixo-cit:fix-invalid-value-for-rate-limit-options-when-updating-compute-region-security-policy-rule
Mar 20, 2026
Merged

Fixed Invalid value for field rateLimitOptions when updating RegionSecurityPolicy rules#16757
zli82016 merged 2 commits intoGoogleCloudPlatform:mainfrom
matheusaleixo-cit:fix-invalid-value-for-rate-limit-options-when-updating-compute-region-security-policy-rule

Conversation

@matheusaleixo-cit
Copy link
Contributor

@matheusaleixo-cit matheusaleixo-cit commented Mar 18, 2026

Updates use of updateMask for rate_limit_options in google_compute_region_security_policy_rule resources.
Also adds tests to replicate the reported issue.

Similar to the fix for global policies from this PR.

Part of: #17275

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: updated request updateMask for `rate_limit_options` field  to `google_compute_region_security_policy_rule` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 18, 2026
@matheusaleixo-cit matheusaleixo-cit marked this pull request as ready for review March 19, 2026 22:55
@github-actions github-actions bot requested a review from zli82016 March 19, 2026 22:55
@github-actions
Copy link

github-actions bot commented Mar 19, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added service/compute-security-policy and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 20, 2026
@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 204 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 204 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

Tests analytics

Total tests: 1394
Passed tests: 1299
Skipped tests: 90
Affected tests: 5

Click here to see the affected service packages
  • compute

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionSecurityPolicyRule_EnforceOnKeyUpdates
  • TestAccComputeRegionSecurityPolicyRule_ruleActionUpdate
  • TestAccComputeRegionSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs
  • TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions
  • TestAccComputeRegionSecurityPolicy_ruleActionUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

modular-magician commented Mar 20, 2026

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionSecurityPolicyRule_EnforceOnKeyUpdates [Debug log]
TestAccComputeRegionSecurityPolicyRule_ruleActionUpdate [Debug log]
TestAccComputeRegionSecurityPolicyRule_withRateLimitOption_withMultipleEnforceOnKeyConfigs [Debug log]
TestAccComputeRegionSecurityPolicyRule_withRateLimitOptions [Debug log]
TestAccComputeRegionSecurityPolicy_ruleActionUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

zli82016
zli82016 approved these changes Mar 20, 2026
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 added this pull request to the merge queue Mar 20, 2026
Merged via the queue into GoogleCloudPlatform:main with commit cb91734 Mar 20, 2026
27 checks passed
This was referenced Mar 20, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zli82016 zli82016 zli82016 approved these changes

Assignees

No one assigned

Labels

service/compute-security-policy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matheusaleixo-cit @modular-magician @zli82016